Benjamin Otte [Thu, 5 Mar 2020 05:57:26 +0000 (06:57 +0100)]
device: Handle missing axis
Benjamin Otte [Thu, 5 Mar 2020 05:53:26 +0000 (06:53 +0100)]
rbtree: Simplify macros
* NODE_FROM_POINTER() can not be NULL
* shuffle NODE_TO_POINTER() code for readability so that the NULL check
is on the outside and not the cast
Benjamin Otte [Thu, 5 Mar 2020 05:51:32 +0000 (06:51 +0100)]
rbtree: Simplify code
This makes it easier to understand for gcc (and hopefully humans, too)
that by rotating we essentially just swap `node` and `p`.
Benjamin Otte [Thu, 5 Mar 2020 02:58:29 +0000 (03:58 +0100)]
build: Add more useful warning flags
I found those on the interwebs and decided they are useful.
Benjamin Otte [Thu, 5 Mar 2020 05:14:58 +0000 (06:14 +0100)]
mountoperation-x11: Fix copy/paste thinko
Benjamin Otte [Wed, 4 Mar 2020 00:24:32 +0000 (01:24 +0100)]
tests: Add a test for changing the hovered widget
The add/remove one crashes after a few enter/leave events.
Benjamin Otte [Thu, 5 Mar 2020 02:57:53 +0000 (03:57 +0100)]
imcontextwayland: Fix copy/paste error
Benjamin Otte [Thu, 5 Mar 2020 02:57:24 +0000 (03:57 +0100)]
textview: Fix copy/paste error
Timm Bäder [Wed, 4 Mar 2020 11:01:30 +0000 (11:01 +0000)]
Merge branch 'patch-1' into 'master'
gdk_monitor_get_model: Fix a typo in the function documentation
See merge request GNOME/gtk!1499
Antenore Gatta [Tue, 3 Mar 2020 09:51:48 +0000 (09:51 +0000)]
gdk_monitor_get_model: Fix a typo in the function documentation
Piotr Drąg [Tue, 3 Mar 2020 16:10:36 +0000 (17:10 +0100)]
Update POTFILES.in
Emmanuele Bassi [Tue, 3 Mar 2020 15:30:43 +0000 (15:30 +0000)]
Merge branch 'doc-fixes' into 'master'
Small documentation fixes
See merge request GNOME/gtk!1500
Emmanuele Bassi [Tue, 3 Mar 2020 13:17:31 +0000 (13:17 +0000)]
Fix annotation for GtkDropTarget.get_gtypes()
The argument name must match in the documentation, and the `allow-none`
annotation is deprecated, and should be replaced by `optional` in this
case.
Emmanuele Bassi [Tue, 3 Mar 2020 13:13:26 +0000 (13:13 +0000)]
Remove incorrect rename-to annotations
The `rename-to` annotation is used to "shadow" a symbol with another
one, which means both symbols need to exist. It can't be used to rename
a symbol to something else.
Emmanuele Bassi [Tue, 3 Mar 2020 13:12:52 +0000 (13:12 +0000)]
Fix introspection warnings for GtkDragIcon
Emmanuele Bassi [Mon, 2 Mar 2020 12:42:43 +0000 (12:42 +0000)]
Add missing annotation for GtkIconTheme
sicklylife [Tue, 3 Mar 2020 12:09:06 +0000 (12:09 +0000)]
Update Japanese translation
sicklylife [Tue, 3 Mar 2020 12:06:32 +0000 (12:06 +0000)]
Update Japanese translation
Matthias Clasen [Tue, 3 Mar 2020 08:40:43 +0000 (08:40 +0000)]
Merge branch 'gbsneto/gtkeventcontrollerfocus' into 'master'
build: Install gtkeventcontrollerfocus.h
See merge request GNOME/gtk!1498
Georges Basile Stavracas Neto [Tue, 3 Mar 2020 03:38:13 +0000 (00:38 -0300)]
build: Install gtkeventcontrollerfocus.h
It's a public class, and is included by gtk.h. Ship it.
Benjamin Otte [Mon, 2 Mar 2020 21:32:20 +0000 (21:32 +0000)]
Merge branch 'wip/otte/for-master' into 'master'
Wip/otte/for master
See merge request GNOME/gtk!1496
Benjamin Otte [Mon, 2 Mar 2020 20:45:59 +0000 (21:45 +0100)]
droptarget: Fast-path local value load
This way, we can ensure that for local same-type drops the GValue
is set when ::enter is emitted.
This is the common case for dnd between widgets inside larger
applications, so it's worth it to speed it up.
Benjamin Otte [Mon, 2 Mar 2020 20:45:42 +0000 (21:45 +0100)]
drop: Don't use g_object_get()
Benjamin Otte [Mon, 2 Mar 2020 20:26:08 +0000 (21:26 +0100)]
dnd: Fix some documentation gotchas
Benjamin Otte [Mon, 2 Mar 2020 18:09:05 +0000 (18:09 +0000)]
Merge branch 'wip/otte/dnd' into 'master'
DND: Sync drop target
See merge request GNOME/gtk!1495
Benjamin Otte [Mon, 2 Mar 2020 03:15:39 +0000 (04:15 +0100)]
drop: Remove unused convenience APIs
With the new event controllers, these are unused.
Benjamin Otte [Mon, 2 Mar 2020 03:10:31 +0000 (04:10 +0100)]
themes: Set proper foreground color for DND icons
Benjamin Otte [Mon, 2 Mar 2020 03:03:03 +0000 (04:03 +0100)]
calendar: Use a drag source
Benjamin Otte [Mon, 2 Mar 2020 02:46:59 +0000 (03:46 +0100)]
dnd: Don't create custom color drag icons
... use the default one. It looks much better.
Benjamin Otte [Mon, 2 Mar 2020 02:11:14 +0000 (03:11 +0100)]
dragicon: Add gtk_drag_icon_create_widget_for_value()
... and use it to set a drag icon.
Benjamin Otte [Mon, 2 Mar 2020 02:39:14 +0000 (03:39 +0100)]
contentformats: Constify some functions
Benjamin Otte [Mon, 2 Mar 2020 01:55:38 +0000 (02:55 +0100)]
dragicon: Change how to acquire drag icons
Before, gtk_drag_icon_new_for_drag() allowed creating new drag icons.
This could cause multiple drag icons to exist for a single drag.
Now, gtk_drag_icon_get_for_drag() makes sure that only one drag icon is
created.
Benjamin Otte [Sun, 1 Mar 2020 21:28:39 +0000 (22:28 +0100)]
dragicon: Add GtkDragIcon::child
Benjamin Otte [Sun, 1 Mar 2020 17:50:15 +0000 (18:50 +0100)]
gdk: Make gdk_drop_status() take preferred action
This allows textview/text dnd to properly display a MOVE icon when in
the widget the drag started from but a COPY icon otherwise.
Benjamin Otte [Sun, 1 Mar 2020 16:32:40 +0000 (17:32 +0100)]
colorswatch: Switch to dragged color during dnd
This is really simple to implement now, so do it.
Benjamin Otte [Sun, 1 Mar 2020 07:45:15 +0000 (08:45 +0100)]
gtk-demo: Add a simple peg solitaire DND demo
Benjamin Otte [Sat, 29 Feb 2020 02:47:17 +0000 (03:47 +0100)]
droptarget: Redo
This is a huge reorganization of GtkDropTarget. I did not know how to
split this up, so it's unfortunately all one commit.
Highlights:
- Split GtkDropTarget into GtkDropTarget and GtkDropTargetAsync
GtkDropTarget is the simple one that only works with GTypes and offers
a synchronous interface.
GtkDropTargetAsync retains the full old functionality and allows
handling mime types.
- Drop events are handled differently
Instead of picking a single drop target and sending all DND events to
it, every event is sent to every drop target. The first one to handle
the event gets to call gdk_drop_status(), further handlers do not
interact with the GdkDrop.
Of course, for the ultimate GDK_DROP_STARTING event, only the first
one to accept the drop gets to handle it.
This allows stacking DND event controllers that aren't necessarily
interested in handling the event or that might decide later to drop
it.
- Port all widgets to either of those
Both have a somewhat changed API due to the new event handling.
For the ones who should use the sync version, lots of cleanup was
involved to operate on a sync API.
Benjamin Otte [Sun, 1 Mar 2020 01:56:09 +0000 (02:56 +0100)]
placessidebar: Don't use the GdkDrag
First, it should have been a GdkDrop, but even then, proper DND code
should not rely on internals.
It's only been used in an unused signal emission anyway.
Benjamin Otte [Sat, 29 Feb 2020 05:29:27 +0000 (06:29 +0100)]
notebook: Make dnd page switching a drop controller
This untangles tab dnd from page switching.
Benjamin Otte [Sat, 29 Feb 2020 03:37:16 +0000 (04:37 +0100)]
textview: Move drop scrolling to drop motion controller
Don't confuse the drop target with it.
Benjamin Otte [Fri, 28 Feb 2020 03:19:36 +0000 (04:19 +0100)]
treeview, iconview: Don't return the drop target
Not a good idea to hand internal event controllers out to public API.
Benjamin Otte [Tue, 25 Feb 2020 21:42:10 +0000 (22:42 +0100)]
testsuite: Use g_assert() in tests
Emmanuele Bassi [Sun, 1 Mar 2020 15:07:17 +0000 (15:07 +0000)]
Merge branch 'piotrdrag/placessidebar-typos' into 'master'
placessidebar: Fix a couple of typos and thinkos in menu labels
See merge request GNOME/gtk!1494
Piotr Drąg [Sun, 1 Mar 2020 14:05:28 +0000 (15:05 +0100)]
placessidebar: Fix a couple of typos and thinkos in menu labels
Matthias Clasen [Sat, 29 Feb 2020 01:19:48 +0000 (01:19 +0000)]
Merge branch 'kill-grabs-2' into 'master'
Kill grabs
See merge request GNOME/gtk!1492
Matthias Clasen [Fri, 28 Feb 2020 21:36:17 +0000 (16:36 -0500)]
Drop gtk_grab_add/remove from public api
The only form in which we still allow grabs to take place
is with modal toplevels.
Matthias Clasen [Fri, 28 Feb 2020 21:29:56 +0000 (16:29 -0500)]
Drop gtk_grab_get_current
Another grab-related api that we are not using.
Matthias Clasen [Fri, 28 Feb 2020 21:27:42 +0000 (16:27 -0500)]
Drop device grabs
We were not using this api at all, so lets drop it.
Matthias Clasen [Fri, 28 Feb 2020 20:35:11 +0000 (20:35 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
inspector: Fix the "Software GL" switch
See merge request GNOME/gtk!1491
Matthias Clasen [Fri, 28 Feb 2020 19:42:19 +0000 (14:42 -0500)]
inspector: Fix the "Software GL" switch
This was crashing.
Piotr Drąg [Thu, 27 Feb 2020 21:05:24 +0000 (22:05 +0100)]
Update POTFILES.in and POTFILES.skip
Matthias Clasen [Thu, 27 Feb 2020 20:29:04 +0000 (20:29 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Matthiasc/for master
See merge request GNOME/gtk!1488
Matthias Clasen [Thu, 27 Feb 2020 19:07:12 +0000 (14:07 -0500)]
Remove a stray g_object_unref
Events are no longer objects, so this does not do
any good. Use gdk_event_unref instead.
Matthias Clasen [Thu, 27 Feb 2020 12:47:37 +0000 (07:47 -0500)]
Avoid a crash in css font features values
Nathan Follens [Thu, 27 Feb 2020 11:05:23 +0000 (11:05 +0000)]
Update Dutch translation
Timm Bäder [Thu, 27 Feb 2020 10:41:44 +0000 (10:41 +0000)]
Merge branch 'patch-1' into 'master'
Fix a typo in gtkplacessidebar.c
See merge request GNOME/gtk!1486
Krzesimir Nowak [Thu, 27 Feb 2020 10:02:56 +0000 (10:02 +0000)]
Fix a typo in gtkplacessidebar.c
Some mistyped vim command got into the code in commit
60d2813247831adf9642f87ad2bf597280d2f31a.
Matthias Clasen [Thu, 27 Feb 2020 01:12:23 +0000 (01:12 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Fix a leftover occurrence of ::expand
See merge request GNOME/gtk!1485
Matthias Clasen [Thu, 27 Feb 2020 00:31:25 +0000 (19:31 -0500)]
Fix a leftover occurrence of ::expand
Danial Behzadi [Wed, 26 Feb 2020 23:23:04 +0000 (23:23 +0000)]
Update Persian translation
Matthias Clasen [Wed, 26 Feb 2020 22:34:45 +0000 (22:34 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
gesture: Actually track targets
See merge request GNOME/gtk!1484
Matthias Clasen [Wed, 26 Feb 2020 22:06:15 +0000 (17:06 -0500)]
gesture: Actually track targets
Due to a mismerge, this wasn't actually working,
and was causing criticals from gtk_widget_has_grab
when dragging windows.
Matthias Clasen [Wed, 26 Feb 2020 14:59:14 +0000 (09:59 -0500)]
builder-tool: Fix a thinko
We can't rely on the pspec for a removed property.
This code worked until I actually removed the properties.
Update the tests to reflect this.
Matthias Clasen [Wed, 26 Feb 2020 14:27:47 +0000 (14:27 +0000)]
Merge branch 'expand-margin-cleanup' into 'master'
expand and margin cleanup
See merge request GNOME/gtk!1479
Matthias Clasen [Wed, 26 Feb 2020 01:57:20 +0000 (20:57 -0500)]
Small fixups
Trying to get the ci style test to pass.
Emmanuele Bassi [Wed, 26 Feb 2020 11:19:09 +0000 (11:19 +0000)]
Merge branch 'docs-fixes' into 'master'
Various documentation fixes
See merge request GNOME/gtk!1481
Emmanuele Bassi [Wed, 26 Feb 2020 10:41:50 +0000 (10:41 +0000)]
Merge branch 'remove-show-hidden' into 'master'
Remove last instances of GtkFileChooser:show-hidden
See merge request GNOME/gtk!1480
Emmanuele Bassi [Wed, 26 Feb 2020 10:29:59 +0000 (10:29 +0000)]
Add missing ownership transfer annotations
Emmanuele Bassi [Wed, 26 Feb 2020 10:25:46 +0000 (10:25 +0000)]
Fix gtk-doc stanza for private symbol
Emmanuele Bassi [Wed, 26 Feb 2020 10:23:15 +0000 (10:23 +0000)]
Add missing documentation to GdkDevice
Emmanuele Bassi [Wed, 26 Feb 2020 10:23:01 +0000 (10:23 +0000)]
Add missing ownership transfer annotations
Emmanuele Bassi [Wed, 26 Feb 2020 10:19:10 +0000 (10:19 +0000)]
Fix introspection annotation syntax
Emmanuele Bassi [Wed, 26 Feb 2020 10:06:22 +0000 (10:06 +0000)]
Remove last instances of GtkFileChooser:show-hidden
The file chooser widget is still setting the show-hidden property, even
though it was removed.
Matthias Clasen [Wed, 26 Feb 2020 01:57:20 +0000 (20:57 -0500)]
Drop the margin property
Replace it with margin-start, -end, -top, -bottom throughout.
Matthias Clasen [Tue, 25 Feb 2020 23:25:52 +0000 (18:25 -0500)]
Drop the expand property
The hexpand and vexpand properties are sufficient.
Matthias Clasen [Tue, 25 Feb 2020 23:25:41 +0000 (18:25 -0500)]
update testsuite
Update the expected results of the tools tests that are
affected by the new property handling for expand and margin.
Matthias Clasen [Tue, 25 Feb 2020 22:50:57 +0000 (17:50 -0500)]
builder-tool: replace some properties
Replace expand by hexpand and vexpand and
margin by margin-left, -right, -top, -bottom.
Emmanuele Bassi [Tue, 25 Feb 2020 19:47:57 +0000 (19:47 +0000)]
Merge branch 'ci-docs' into 'master'
Restructure CI jobs
See merge request GNOME/gtk!1476
Emmanuele Bassi [Tue, 25 Feb 2020 19:06:39 +0000 (19:06 +0000)]
ci: Add a static analysis job
Use the Clang static analysis tool.
For the time being, we're going to allow it to fail, but the plan is to
fix every issue it raises.
Emmanuele Bassi [Tue, 25 Feb 2020 19:05:07 +0000 (19:05 +0000)]
ci: Update the docker wrapper script
Do a better job at detecting whether we have Docker installed.
Emmanuele Bassi [Tue, 25 Feb 2020 17:57:46 +0000 (17:57 +0000)]
ci: Move style-check to .pre phase
We want the style checks running at the start of the CI pipeline, no
need to have a specific phase for it.
Emmanuele Bassi [Tue, 25 Feb 2020 17:19:08 +0000 (17:19 +0000)]
ci: Update all fedora images to v14
Emmanuele Bassi [Tue, 25 Feb 2020 17:18:23 +0000 (17:18 +0000)]
ci: Add clang-analyzer to the fedora build image
Emmanuele Bassi [Tue, 25 Feb 2020 17:15:00 +0000 (17:15 +0000)]
ci: Rename the "style-check" phase to "analysis"
We want to re-use it for other jobs.
Emmanuele Bassi [Tue, 25 Feb 2020 17:13:39 +0000 (17:13 +0000)]
ci: Fix style check script
Propagate the exit status from clang-format-diff.py to avoid it being
overwritten by the `echo` at the end of the script.
Emmanuele Bassi [Tue, 25 Feb 2020 16:42:07 +0000 (16:42 +0000)]
ci: Add a separate "docs" stage
Don't build the API reference on deploy; build it in a separate job,
instead, so we can run it on all pipelines, and deploy it only for
master.
Timm Bäder [Tue, 25 Feb 2020 13:35:34 +0000 (13:35 +0000)]
Merge branch 'wip/baedert/for-master' into 'master'
wip/baedert/for-master
See merge request GNOME/gtk!1466
Timm Bäder [Sun, 23 Feb 2020 15:53:53 +0000 (16:53 +0100)]
statusbar: Remove _get_message_area() from public API
The message should be manipulated via push() and pop().
Timm Bäder [Sun, 23 Feb 2020 15:08:23 +0000 (16:08 +0100)]
scrolledwindow: Remove an unnecessary cast
Timm Bäder [Sun, 23 Feb 2020 14:57:10 +0000 (15:57 +0100)]
scrolledwindow: Remove useless local variables
Timm Bäder [Sat, 22 Feb 2020 15:13:34 +0000 (16:13 +0100)]
widget: Remove gtk_widget_input_shape_combine_region()
Widget's don't have surfaces anymore these days.
Timm Bäder [Sat, 22 Feb 2020 15:07:12 +0000 (16:07 +0100)]
inspect-button: Use new gtk_window_set_extra_input_region
Timm Bäder [Sat, 22 Feb 2020 15:05:35 +0000 (16:05 +0100)]
window: Carry an extra input region
This will be used in the inspector to make it possible to click through
the inspector window.
Timm Bäder [Sat, 22 Feb 2020 14:28:44 +0000 (15:28 +0100)]
popover: Stop using gtk_widget_input_shape_combine_region()
We control the surface anyway, we can as well set the input shape on it
directly.
Timm Bäder [Sat, 22 Feb 2020 14:25:49 +0000 (15:25 +0100)]
widget: Remove set_csd_input_shape
Replace the only caller (unsurprisingly from gtkwindow.c) with a direct
call to gdk_surface_input_shape_combine_region.
Timm Bäder [Sat, 22 Feb 2020 13:55:52 +0000 (14:55 +0100)]
widget: Remove surface member
Only GtkNatives are supposed to have a surface, so use the widget's
native.
Timm Bäder [Sat, 22 Feb 2020 13:12:16 +0000 (14:12 +0100)]
range: Remove an outdated comment
What even is a CList.
Timm Bäder [Sat, 22 Feb 2020 13:11:05 +0000 (14:11 +0100)]
range: Inline function into only caller
Timm Bäder [Sat, 22 Feb 2020 13:04:06 +0000 (14:04 +0100)]
range: Clean up compute_slider_position()
Timm Bäder [Sat, 22 Feb 2020 08:07:48 +0000 (09:07 +0100)]
menusectionbox: Avoid a gtk_widget_destroy() call